Re: [PATCH v5 03/26] dt-bindings: leds: Add LED_FUNCTION definitions

[Geert Uytterhoeven]

Hi Jacek,

On Sun, Jun 9, 2019 at 9:09 PM Jacek Anaszewski
<jacek.anaszewski@xxxxxxxxx> wrote:
> Add initial set of common LED function definitions.
>
> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>

> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -30,4 +31,45 @@
>  #define LED_COLOR_ID_IR                7
>  #define LED_COLOR_ID_MAX       8
>
> +/* Standard LED functions */
> +#define LED_FUNCTION_ACTIVITY "activity"

What's the appropriate function for "general purpose" or "user" LEDs on
development boards, where the LEDs don't have fixed functions, unlike
on real products?
Perhaps just LED_FUNCTION_INDICATOR?

I noticed your very initial submission defined LED_FUNCTION_USER "user".
I couldn't find an explanation for the rationale behind its removal in later
revisions, or any discussion asking for that.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds