Re: [PATCH v2 1/2] x86/speculation: Fix incorrect MDS/TAA mitigation status

From: Boris Petkov
Date: Fri Nov 15 2019 - 12:09:30 EST


On November 15, 2019 5:14:44 PM GMT+01:00, Waiman Long <longman@xxxxxxxxxx> wrote:
>For MDS vulnerable processors with TSX support, enabling either MDS or
>TAA mitigations will enable the use of VERW to flush internal processor
>buffers at the right code path. IOW, they are either both mitigated
>or both not. However, if the command line options are inconsistent,
>the vulnerabilites sysfs files may not report the mitigation status
>correctly.
>
>For example, with only the "mds=off" option:
>
> vulnerabilities/mds:Vulnerable; SMT vulnerable
>vulnerabilities/tsx_async_abort:Mitigation: Clear CPU buffers; SMT
>vulnerable
>
>The mds vulnerabilities file has wrong status in this case. Similarly,
>the taa vulnerability file will be wrong with mds mitigation on, but
>taa off.
>
>Change taa_select_mitigation() to sync up the two mitigation status
>and have them turned off if both "mds=off" and "tsx_async_abort=off"
>are present.
>
>Both hw-vuln/mds.rst and hw-vuln/tsx_async_abort.rst are updated
>to emphasize the fact that both "mds=off" and "tsx_async_abort=off"
>have to be specified together for processors that are affected by both
>TAA and MDS to be effective. As kernel-parameter.txt references both
>documents above, it is not necessary to update it.

What about kernel-parameters.txt?

--
Sent from a small device: formatting sux and brevity is inevitable.