Re: [PATCH] tpm_tis: Move setting of TPM_CHIP_FLAG_IRQ into tpm_tis_probe_irq_single

[Stefan Berger]

On 11/14/19 11:44 AM, Jarkko Sakkinen wrote:
> On Thu, Nov 14, 2019 at 06:41:51PM +0200, Jarkko Sakkinen wrote:
> > On Tue, Nov 12, 2019 at 03:27:25PM -0500, Stefan Berger wrote:
> > > From: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> > >
> > > Move the setting of the TPM_CHIP_FLAG_IRQ for irq probing into
> > > tpm_tis_probe_irq_single before calling tpm_tis_gen_interrupt.
> > > This move handles error conditions better that may arise if anything
> > > before fails in tpm_tis_probe_irq_single.
> > >
> > > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> > > Suggested-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>
> > What about just changing the condition?
> Also cannot take this since it is not a bug (no fixes tag).

I'll repost but will wait until Jerry has tested it on that machine.

ÂÂ Stefan


> /Jarkko