Re: [PATCH 03/13] exfat: add inode operations
From: Markus Elfring
Date: Sun Nov 17 2019 - 09:16:04 EST
â
> +++ b/fs/exfat/inode.c
â
> +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t mode,
> + bool excl)
> +{
â
+out:
+ mutex_unlock(&EXFAT_SB(sb)->s_lock);
Can the label âunlockâ be more appropriate?
> +static struct dentry *exfat_lookup(struct inode *dir, struct dentry *dentry,
> + unsigned int flags)
> +{
â
> +error:
> + mutex_unlock(&EXFAT_SB(sb)->s_lock);
Would you like to use the label âunlockâ also at this place (and similar ones)?
> +static int exfat_search_empty_slot(struct super_block *sb,
> + struct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir,
> + int num_entries)
> +{
â
> +out:
> + kfree(clu);
How do you think about to rename the label to âfree_cluâ?
Regards,
Markus