[PATCH 2/3] selftests/clone3: report a correct number of fails

From: Andrei Vagin
Date: Mon Nov 18 2019 - 01:48:10 EST


In clone3_set_tid, a few test cases are running in a child process. And
right now, if one of these test cases fails, the whole test will exit
with the success status.

Signed-off-by: Andrei Vagin <avagin@xxxxxxxxx>
---
tools/testing/selftests/clone3/clone3_set_tid.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/tools/testing/selftests/clone3/clone3_set_tid.c b/tools/testing/selftests/clone3/clone3_set_tid.c
index e93369dcfe3b..9c19bae03661 100644
--- a/tools/testing/selftests/clone3/clone3_set_tid.c
+++ b/tools/testing/selftests/clone3/clone3_set_tid.c
@@ -316,7 +316,7 @@ int main(int argc, char *argv[])
*/
test_clone3_set_tid(set_tid, 3, CLONE_NEWPID, 0, 42, true);

- child_exit(ksft_cnt.ksft_pass);
+ child_exit(ksft_cnt.ksft_fail);
}

close(pipe_1[1]);
@@ -366,12 +366,8 @@ int main(int argc, char *argv[])
if (!WIFEXITED(status))
ksft_test_result_fail("Child error\n");

- if (WEXITSTATUS(status))
- /*
- * Update the number of total tests with the tests from the
- * child processes.
- */
- ksft_cnt.ksft_pass = WEXITSTATUS(status);
+ ksft_cnt.ksft_pass += 4 - (ksft_cnt.ksft_fail - WEXITSTATUS(status));
+ ksft_cnt.ksft_fail = WEXITSTATUS(status);

if (ns3 == pid && ns2 == 42 && ns1 == 1)
ksft_test_result_pass(
--
2.23.0