Re: [PATCH v1 1/4] tps6105x: add optional devicetree support

From: Sven Van Asbroeck
Date: Mon Nov 18 2019 - 12:18:06 EST

On Mon, Nov 18, 2019 at 12:01 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> We shouldn't need a compatible here, the MFD should just instantiate any
> children it has.

If the child node doesn't have a compatible, how would the driver be
able to work
out the operational mode? The chip can only be in a single operational mode
at a time. So the child node has 'led' or 'regulator' compatible.

Or is there a more elegant method I've overlooked?

> This also doesn't document any actual regulators on
> the device.

The chip contains a single optional regulator only. I documented its
dt bindings later in the patchset.