Re: [PATCH][next] net: phy: dp83869: fix return of uninitialized variable ret

From: David Miller
Date: Mon Nov 18 2019 - 20:24:00 EST

From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Mon, 18 Nov 2019 11:48:35 +0000

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> In the case where the call to phy_interface_is_rgmii returns zero
> the variable ret is left uninitialized and this is returned at
> the end of the function dp83869_configure_rgmii. Fix this by
> returning 0 instead of the uninitialized value in ret.
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 01db923e8377 ("net: phy: dp83869: Add TI dp83869 phy")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>