Re: [PATCH v8 0/5] Add a unified parameter "nopvspin"

[Zhenzhong Duan]

Hi Maintainers,

May I get a final update on this patchset?

There is only a few days remaining before my layoff at Oracle. I can't 
login the mail address after that.

No matter if you prefer to reject it, please let me know. I'd like to 
get an end to this patchset.

Thanks

Zhenzhong


On 2019/10/29 9:33, Zhenzhong Duan wrote:
> Hi Baolo, Thomas
>
> This patchset is reviewed pass and keep silent for a while, will 
> anyone of you
>
> consider to pick it up? Thanks
>
> Zhenzhong
>
> On 2019/10/23 19:16, Zhenzhong Duan wrote:
> > There are cases folks want to disable spinlock optimization for
> > debug/test purpose. Xen and hyperv already have parameters 
> > "xen_nopvspin"
> > and "hv_nopvspin" to support that, but kvm doesn't.
> >
> > The first patch adds that feature to KVM guest with "nopvspin".
> >
> > For compatibility reason original parameters "xen_nopvspin" and
> > "hv_nopvspin" are retained and marked obsolete.
> >
> > v8:
> > PATCH2: use 'kvm-guest' instead of 'kvm_guest'ÂÂÂÂÂÂÂ [Sean 
> > Christopherson]
> > PATCH3: add a comment to explain missed 'return'ÂÂÂÂÂ [Sean 
> > Christopherson]
> >
> > v7:
> > PATCH3: update comment and use goto, add RBÂÂÂÂÂÂÂÂÂÂÂÂÂ [Vitaly 
> > Kuznetsov]
> >
> > v6:
> > PATCH1: add Reviewed-byÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ [Vitaly 
> > Kuznetsov]
> > PATCH2: change 'pv' to 'PV', add Reviewed-byÂÂÂÂÂÂÂÂÂÂÂÂ [Vitaly 
> > Kuznetsov]
> > PATCH3: refactor 'if' branch in kvm_spinlock_init()ÂÂÂÂÂ [Vitaly 
> > Kuznetsov]
> >
> > v5:
> > PATCH1: new patch to revert a currently unnecessory commit,
> > ÂÂÂÂÂÂÂÂ code is simpler a bit after that change.ÂÂÂÂÂÂÂÂ [Boris 
> > Ostrovsky]
> > PATCH3: fold 'if' statement,add comments on virt_spin_lock_key,
> > ÂÂÂÂÂÂÂÂ reorder with PATCH2 to better reflect dependency
> > PATCH4: fold 'if' statement, add Reviewed-byÂÂÂÂÂÂÂÂÂÂÂÂ [Boris 
> > Ostrovsky]
> > PATCH5: add Reviewed-by [Michael Kelley]
> >
> > v4:
> > PATCH1: use variable name nopvspin instead of pvspin and
> > ÂÂÂÂÂÂÂÂ defined it as __initdata, changed print message,
> > ÂÂÂÂÂÂÂÂ updated patch descriptionÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ [Sean 
> > Christopherson]
> > PATCH2: remove Suggested-by, use "kvm-guest:" prefix [Sean 
> > Christopherson]
> > PATCH3: make variable nopvsin and xen_pvspin coexist
> > ÂÂÂÂÂÂÂÂ remove Reviewed-by due to code changeÂÂÂÂÂÂÂÂ [Sean 
> > Christopherson]
> > PATCH4: make variable nopvsin and hv_pvspin coexistÂÂ [Sean 
> > Christopherson]
> >
> > v3:
> > PATCH2: Fix indentation
> >
> > v2:
> > PATCH1: pick the print code change into separate PATCH2,
> > ÂÂÂÂÂÂÂÂ updated patch descriptionÂÂÂÂÂÂÂÂÂÂÂÂ [Vitaly Kuznetsov]
> > PATCH2: new patch with print code changeÂÂÂÂÂ [Vitaly Kuznetsov]
> > PATCH3: add Reviewed-byÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ [Juergen Gross]
> >
> > Zhenzhong Duan (5):
> > ÂÂ Revert "KVM: X86: Fix setup the virt_spin_lock_key before static key
> > ÂÂÂÂ get initialized"
> > ÂÂ x86/kvm: Change print code to use pr_*() format
> > ÂÂ x86/kvm: Add "nopvspin" parameter to disable PV spinlocks
> > ÂÂ xen: Mark "xen_nopvspin" parameter obsolete
> > ÂÂ x86/hyperv: Mark "hv_nopvspin" parameter obsolete
> >
> > Â Documentation/admin-guide/kernel-parameters.txt | 14 ++++-
> > Â arch/x86/hyperv/hv_spinlock.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 4 ++
> > Â arch/x86/include/asm/qspinlock.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 1 +
> > Â arch/x86/kernel/kvm.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 79 
> > ++++++++++++++++---------
> > Â arch/x86/xen/spinlock.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 4 +-
> > Â kernel/locking/qspinlock.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 7 +++
> > Â 6 files changed, 76 insertions(+), 33 deletions(-)