Re: [PATCH v3 00/13] add the latest exfat driver

From: Namjae Jeon
Date: Tue Nov 19 2019 - 07:43:57 EST


2019-11-19 21:15 GMT+09:00, Markus Elfring <Markus.Elfring@xxxxxx>:
>> â, an a random previous
>
> Does this wording contain a typo?
Yes, Will fix it on next series.

>
>
>> We plan to treat this version as the future upstream for the code base
>> once merged, and all new features and bug fixes will go upstream first.
>
> Were the following mentioned issues occasionally reviewed already
> by other developers before?
https://marc.info/?l=linux-fsdevel&m=156985252507812&w=2

>
>
>> v3:
>> - fix wrong sbi->s_dirt set.
>>
>> v2:
>> - Check the bitmap count up to the total clusters.
>> - Rename proper goto labels in seveal place.
>
> Would you like to avoid further typos in such change descriptions?
Will fix on next series.
>
>
>> - Change time mode type with enumeration.
>
> How do you think about to increase the usage of enumerations
> at any more source code places?
I will check.
>
>
>> - Directly return error instead of goto at first error check.
>> - Combine seq_printfs calls into a single one.
>
> Please refer to the correct function name.
Okay:)
>
>
> Thanks for your positive feedback.
Thanks for your review!
>
> Regards,
> Markus
>