Re: [PATCH v3 02/13] exfat: add super block operations

[Markus Elfring]

â
> +++ b/fs/exfat/super.c
â
> +static int __exfat_fill_super(struct super_block *sb)
> +{
â
> +free_upcase:
> +	exfat_free_upcase_table(sb);

Label alternatives?
* free_table
* free_upcase_table


â
> +static int exfat_fill_super(struct super_block *sb, struct fs_context *fc)
> +{
â
> +	if (EXFAT_SB(sb)->options.case_sensitive)
> +		sb->s_d_op = &exfat_dentry_ops;
> +	else
> +		sb->s_d_op = &exfat_ci_dentry_ops;

How do you think about the usage of conditional operators at similar places?

+	sb->s_d_op = EXFAT_SB(sb)->options.case_sensitive
+		     ? &exfat_dentry_ops;
+		     : &exfat_ci_dentry_ops;


â
> +failed_mount3:
> +	iput(root_inode);

I find the label âput_inodeâ more appropriate.


â
> +failed_mount2:
> +	exfat_free_upcase_table(sb);

I find the label âfree_tableâ more helpful.


â
> +failed_mount:
> +	if (sbi->nls_io)
> +		unload_nls(sbi->nls_io);

Can the label âcheck_nls_ioâ be nicer?


â
> +static int __init init_exfat_fs(void)
> +{
â
> +shutdown_cache:
> +	exfat_cache_shutdown();
> +
> +	return err;

Would you like to omit blank lines at similar places?

Regards,
Markus