Re: [PATCH v3 06/13] exfat: add exfat entry operations

From: Markus Elfring
Date: Tue Nov 19 2019 - 09:19:24 EST


â
> +++ b/fs/exfat/fatent.c
â
> +int exfat_zeroed_cluster(struct inode *dir, unsigned int clu)
> +{
â
> +error:
> + exfat_msg(sb, KERN_ERR, "failed zeroed sect %llu\n",
> + (unsigned long long)blknr);
â

Can the label âreport_failureâ be more helpful?


â
> +int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc,
> + struct exfat_chain *p_chain)
> +{
â
> +error:
> + if (num_clusters)
> + exfat_free_cluster(inode, p_chain);

Can a label like âcheck_num_clustersâ be nicer?

Regards,
Markus