Re: [PATCH v3 1/2] dt-bindings: power: Convert Generic Power Domain bindings to json-schema

From: Krzysztof Kozlowski
Date: Tue Nov 19 2019 - 09:32:20 EST


On Tue, Nov 19, 2019 at 10:58:11AM +0100, Geert Uytterhoeven wrote:
> Hi Rob, Krzysztof,
>
> On Thu, Nov 14, 2019 at 5:42 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> > On Thu, Nov 14, 2019 at 6:59 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > > On Tue, Nov 05, 2019 at 01:42:58PM -0600, Rob Herring wrote:
> > > > On Wed, 30 Oct 2019 18:32:15 +0100, Krzysztof Kozlowski wrote:
> > > > > Convert Generic Power Domain bindings to DT schema format using
> > > > > json-schema.
> > > > >
> > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > > > > Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > > > > Acked-by: Stephen Boyd <sboyd@xxxxxxxxxx>
> > > > >
> > > > > ---
> > > > >
> > > > > Changes since v2:
> > > > > 1. Keep description of consumers in power-domain.txt,
> > > > > 2. Rename power_domain.txt to power-domain.txt,
> > > > > 3. Indent example with four spaces (more readable).
> > > > >
> > > > > Changes since v1:
> > > > > 1. Select all nodes for consumers,
> > > > > 2. Remove from consumers duplicated properties with dt-schema,
> > > > > 3. Fix power domain pattern,
> > > > > 4. Remove unneeded types.
> > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > > > > ---
> > > > > .../devicetree/bindings/arm/arm,scmi.txt | 2 +-
> > > > > .../devicetree/bindings/arm/arm,scpi.txt | 2 +-
> > > > > .../bindings/arm/freescale/fsl,scu.txt | 2 +-
> > > > > .../bindings/clock/renesas,cpg-mssr.txt | 2 +-
> > > > > .../bindings/clock/ti/davinci/psc.txt | 2 +-
> > > > > .../firmware/nvidia,tegra186-bpmp.txt | 2 +-
> > > > > .../bindings/power/amlogic,meson-gx-pwrc.txt | 2 +-
> > > > > .../devicetree/bindings/power/fsl,imx-gpc.txt | 2 +-
> > > > > .../bindings/power/fsl,imx-gpcv2.txt | 2 +-
> > > > > .../{power_domain.txt => power-domain.txt} | 95 +------------
> > > > > .../bindings/power/power-domain.yaml | 133 ++++++++++++++++++
> > > > > .../bindings/power/renesas,sysc-rmobile.txt | 2 +-
> > > > > .../bindings/power/xlnx,zynqmp-genpd.txt | 2 +-
> > > > > .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 2 +-
> > > > > .../bindings/soc/mediatek/scpsys.txt | 2 +-
> > > > > .../bindings/soc/ti/sci-pm-domain.txt | 2 +-
> > > > > MAINTAINERS | 2 +-
> > > > > 17 files changed, 149 insertions(+), 109 deletions(-)
> > > > > rename Documentation/devicetree/bindings/power/{power_domain.txt => power-domain.txt} (51%)
> > > > > create mode 100644 Documentation/devicetree/bindings/power/power-domain.yaml
> > > > >
> > > >
> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > >
> > > The patches should apply cleanly in top of your tree so maybe you can
> > > pick them up?
> >
> > I didn't on this one because it touches a lot of files. Though on
> > second thought, they are all across the tree, so I might as well apply
> > them.
>
> There are still several leftover references to power_domain.txt.
> Krzysztof: Do you plan to convert these, too, or do you expect the
> individual maintainers to handle that?

Ahh, I think that's my fault after one of iterations of the patchset. I
can fix it up fast and maybe let's queue it through the same tree (Rob's).

Best regards,
Krzysztof