Re: [PATCH net v3] net: fec: fix clock count mis-match
From: David Miller
Date: Tue Nov 19 2019 - 17:55:16 EST
From: Chuhong Yuan <hslester96@xxxxxxxxx>
Date: Mon, 18 Nov 2019 20:18:26 +0800
> pm_runtime_put_autosuspend in probe will call suspend to disable clks
> automatically if CONFIG_PM is defined. (If CONFIG_PM is not defined,
> its implementation will be empty, then suspend will not be called.)
>
> Therefore, we can call pm_runtime_get_sync to resume it first to enable
> clks, which matches the suspend. (Only when CONFIG_PM is defined, otherwise
> pm_runtime_get_sync will also be empty, then resume will not be called.)
>
> Then it is fine to disable clks without causing clock count mis-match.
>
> Fixes: c43eab3eddb4 ("net: fec: add missed clk_disable_unprepare in remove")
> Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>
Please fix the commit message typos pointed out by Andy Duan and resubmit,
thank you.