Re: [net PATCH v2] taprio: don't reject same mqprio settings

From: David Miller
Date: Tue Nov 19 2019 - 18:33:55 EST


From: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>
Date: Tue, 19 Nov 2019 02:23:12 +0200

> The taprio qdisc allows to set mqprio setting but only once. In case
> if mqprio settings are provided next time the error is returned as
> it's not allowed to change traffic class mapping in-flignt and that
> is normal. But if configuration is absolutely the same - no need to
> return error. It allows to provide same command couple times,
> changing only base time for instance, or changing only scheds maps,
> but leaving mqprio setting w/o modification. It more corresponds the
> message: "Changing the traffic mapping of a running schedule is not
> supported", so reject mqprio if it's really changed.
>
> Also corrected TC_BITMASK + 1 for consistency, as proposed.
>
> Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule")
> Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>
> Tested-by: Vladimir Oltean <olteanv@xxxxxxxxx>
> Acked-by: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxx>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>

Applied and queued up for -stable.