Re: [PATCH V2 1/2] cpuidle: Replace use_deepest_state flag by forced_idle_latency_limit_ns

From: Daniel Lezcano
Date: Wed Nov 20 2019 - 06:32:46 EST


On 20/11/2019 12:05, Rafael J. Wysocki wrote:
> On Saturday, November 16, 2019 2:16:12 PM CET Daniel Lezcano wrote:
>> We want to specify a latency constraint when choosing an idle state at
>> play_idle time. Instead of duplicating the information in the
>> structure or propagate the latency in the call stack, change the
>> use_deepest_state by forced_latency_limit_ns to introduce this
>> constraint. The idea being that when it is set, idle is forced
>> (i.e. no governors), but there is a latency limit for the state to
>> use.
>>
>> A zero latency constraint means "do not use the deepest idle state
>> path" as the 'use_deepest_state' boolean was used in the
>> cpuidle_idle_call.
>>
>> In addition add the play_idle_precise() function getting a nanosec
>> base latency constraint as parameter. The play_idle() function becomes
>> a wrapper passing an U64_MAX to play_idle_precise().
>>
>> Suggested-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
>> ---

[ ... ]

> Queued up for 5.5 along with the [2/2], but I have made quite a few changes
> to the patches, so please double check the result in my bleeding-edge branch.
>
> Thanks!

They look good to me.

Thanks

-- Daniel


--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog