Re: [PATCH 1/6] soc: qcom: rpmhpd: Set 'active_only' for active only power domains

[Sibi Sankar]

On 2019-11-20 08:09, Bjorn Andersson wrote:
> On Mon 18 Nov 09:40 PST 2019, Sibi Sankar wrote:
>
> > From: Douglas Anderson <dianders@xxxxxxxxxxxx>
> >
> > The 'active_only' attribute was accidentally never set to true for any
> > power domains meaning that all the code handling this attribute was
> > dead.
> >
> > NOTE that the RPM power domain code (as opposed to the RPMh one) gets
> > this right.
> >
> > Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain 
> > driver")
> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> > Acked-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
>
> You should have added your S-o-b here to certify its origin.
> But I picked up this patch earlier today.

sry missed it

> Thanks,
> Bjorn
>
> > ---
> >  drivers/soc/qcom/rpmhpd.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> > index 5741ec3fa814c..51850cc68b701 100644
> > --- a/drivers/soc/qcom/rpmhpd.c
> > +++ b/drivers/soc/qcom/rpmhpd.c
> > @@ -93,6 +93,7 @@ static struct rpmhpd sdm845_mx = {
> >
> >  static struct rpmhpd sdm845_mx_ao = {
> >  	.pd = { .name = "mx_ao", },
> > +	.active_only = true,
> >  	.peer = &sdm845_mx,
> >  	.res_name = "mx.lvl",
> >  };
> > @@ -107,6 +108,7 @@ static struct rpmhpd sdm845_cx = {
> >
> >  static struct rpmhpd sdm845_cx_ao = {
> >  	.pd = { .name = "cx_ao", },
> > +	.active_only = true,
> >  	.peer = &sdm845_cx,
> >  	.parent = &sdm845_mx_ao.pd,
> >  	.res_name = "cx.lvl",
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
> > Forum,
> > a Linux Foundation Collaborative Project

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.