Re: [PATCH] arm: Fix topology setup in case of CPU hotplug for CONFIG_SCHED_MC

[Dietmar Eggemann]

On 20.11.19 11:09, Sudeep Holla wrote:
> Hi Dietmar, Lukasz,
> 
> Thanks for digging this bug and fixing it.
> 
> On Wed, Nov 20, 2019 at 10:42:12AM +0000, Dietmar Eggemann wrote:

[...]

>> @@ -231,14 +230,14 @@ void store_cpu_topology(unsigned int cpuid)
>>  		cpuid_topo->package_id = -1;
>>  	}
>>
>> -	update_siblings_masks(cpuid);
>> -
>>  	update_cpu_capacity(cpuid);
>>
>>  	pr_info("CPU%u: thread %d, cpu %d, socket %d, mpidr %x\n",
>> -		cpuid, cpu_topology[cpuid].thread_id,
>> -		cpu_topology[cpuid].core_id,
>> -		cpu_topology[cpuid].package_id, mpidr);
>> +		cpuid, cpuid_topo->thread_id, cpuid_topo->core_id,
>> +		cpuid_topo->package_id, mpidr);
>> +
> 
> [nit] The above is a clearly cosmetic cleanup and shouldn't be part of
> this fix as they will be backported automatically. So I prefer to drop
> this or make it separate patch if required.

I can get rid of this cleanup in v2. Thanks for the review!