Re: [PATCH v3 10/13] exfat: add nls operations

From: Markus Elfring
Date: Wed Nov 20 2019 - 07:36:27 EST


>> â
>>> +++ b/fs/exfat/nls.c
>> â
>>> +static int exfat_load_upcase_table(struct super_block *sb,
>>> + sector_t sector, unsigned long long num_sectors,
>>> + unsigned int utbl_checksum)
>>> +{
>> â
>>> +error:
>>> + if (bh)
>>> + brelse(bh);
â
>> Can the label ârelease_bhâ be more helpful?
â
> I checked not only review point but also your review points in
> other patches, I will fix them on v4.
â

Another software design alternative would be to use a jump target
like âfree_tableâ instead at this source code place, wouldn't it?

Regards,
Markus