[PATCH 2/2] driver core: Print device in really_probe() warning backtrace

From: Geert Uytterhoeven
Date: Wed Nov 20 2019 - 09:36:26 EST


If a device already has devres items attached before probing, a warning
backtrace is printed. However, this backtrace does not reveal the
offending device, leaving the user uninformed.

Use dev_WARN_ON() instead of WARN_ON() to fix this.

Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
---
drivers/base/dd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index d811e60610d33ae9..a7e8040ef0003f44 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -516,7 +516,7 @@ static int really_probe(struct device *dev, struct device_driver *drv)
atomic_inc(&probe_count);
pr_debug("bus: '%s': %s: probing driver %s with device %s\n",
drv->bus->name, __func__, drv->name, dev_name(dev));
- WARN_ON(!list_empty(&dev->devres_head));
+ dev_WARN_ON(dev, !list_empty(&dev->devres_head));

re_probe:
dev->driver = drv;
--
2.17.1