Re: [PATCH v3 2/3] leds: tps6105x: add driver for mfd chip led mode

[Jacek Anaszewski]

On 11/20/19 10:41 PM, Sven Van Asbroeck wrote:
> Hi Jacek,
> 
> On Wed, Nov 20, 2019 at 4:33 PM Jacek Anaszewski
> <jacek.anaszewski@xxxxxxxxx> wrote:
>> This is covered in DT bindings, it is redundant in the commit message.
> 
> Ok, I will remove it from the commit message.
> 
>>> +     priv->cdev.name = "tps6105x::torch";
>>
>> Please remove above line.
>>
>> And use new LED registration API like below:
>>
>> struct led_init_data init_data = {
>>         .devicename = "tps6105x",
>>         .default_label = ":torch" };
>>
>> return devm_led_classdev_register_ext(&pdev->dev, &priv->cdev, &init_data);
> 
> I would love to do that, but my platform (with a tps6105x) can only boot a lts
> vendor kernel (4.14). classdev_register_ext() is not available there.
> 
> I can make the change you suggest, but cannot test to check if it will actually
> work. Is that ok for you?

Can't you backport also the LED core patches with *ext API?

-- 
Best regards,
Jacek Anaszewski