Re: [PATCH 4.19 065/422] ice: Fix and update driver version string

[Pavel Machek]

On Tue 2019-11-19 06:14:22, Greg Kroah-Hartman wrote:
> From: Anirudh Venkataramanan <anirudh.venkataramanan@xxxxxxxxx>
> 
> [ Upstream commit 9ea47d81a7f17c6b77211ab75fbca2127719ad39 ]
> 
> Remove the "ice" prefix for the driver version string and bump version
> to 0.7.1-k.

This sounds like a bad idea. 0.7.1 in mainline contains patches that
were not backported to stable, so marking this as 0.7.1 version is
wrong.

Best regards,
								Pavel
								
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -7,7 +7,7 @@
>  
>  #include "ice.h"
>  
> -#define DRV_VERSION	"ice-0.7.0-k"
> +#define DRV_VERSION	"0.7.1-k"
>  #define DRV_SUMMARY	"Intel(R) Ethernet Connection E800 Series Linux Driver"
>  const char ice_drv_ver[] = DRV_VERSION;
>  static const char ice_driver_string[] = DRV_SUMMARY;
> -- 
> 2.20.1
> 
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature