Re: [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers

[Vinod Koul]

On 06-11-19, 14:08, Vinod Koul wrote:
> This series add support for Renesas USB controllers uPD720201 and uPD720202.
> These require firmware to be loaded and in case devices have ROM those can
> also be programmed if empty. If ROM is programmed, it runs from ROM as well.
> 
> This includes two patches from Christian which supported these controllers
> w/o ROM and later my patches for ROM support and multiple firmware versions.

Greg, Mathias

Any feedback on this?

> 
> Changes in v5:
>  Added a debugfs rom erase patch, helps in debugging
>  Squashed patch 1 & 2 as requested by Mathias
> 
> Changes in v4:
>  Rollback the delay values as we got device failures
> 
> Changes in v3:
>   Dropped patch 2 as discussed with Christian
>   Removed aligned 8 bytes check
>   Change order for firware search from highest version to lowest
>   Added entry for new firmware for device 0x14 as well
>   Add tested by Christian
> 
> Changes in v2:
>   used macros for timeout count and delay
>   removed renesas_fw_alive_check
>   cleaned renesas_fw_callback
>   removed recurion for renesas_fw_download
>   added MODULE_FIRMWARE
>   added comment for multiple fw order
> 
> Christian Lamparter (1):
>   usb: xhci: add firmware loader for uPD720201 and uPD720202 w/o ROM
> 
> Vinod Koul (3):
>   usb: xhci: Add ROM loader for uPD720201
>   usb: xhci: allow multiple firmware versions
>   usb: xhci: provide a debugfs hook for erasing rom
> 
>  drivers/usb/host/xhci-pci.c | 911 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 911 insertions(+)
> 
> -- 
> 2.23.0

-- 
~Vinod