RE: [PATCH v6 0/8] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling

[Manish Narani]

Hi Uffe, Rob and Adrian,

> -----Original Message-----
> From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Sent: Wednesday, November 20, 2019 6:29 PM
> To: Manish Narani <MNARANI@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland
> <mark.rutland@xxxxxxx>; Adrian Hunter <adrian.hunter@xxxxxxxxx>;
> Michal Simek <michals@xxxxxxxxxx>; Jolly Shah <JOLLYS@xxxxxxxxxx>; Rajan
> Vaja <RAJANV@xxxxxxxxxx>; Nava kishore Manne <navam@xxxxxxxxxx>;
> Moritz Fischer <mdf@xxxxxxxxxx>; linux-mmc@xxxxxxxxxxxxxxx; DTML
> <devicetree@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>; Linux ARM <linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx>; git <git@xxxxxxxxxx>
> Subject: Re: [PATCH v6 0/8] Arasan SDHCI enhancements and ZynqMP Tap
> Delays Handling
> 
> On Wed, 20 Nov 2019 at 07:47, Manish Narani <manish.narani@xxxxxxxxxx>
> wrote:
> >
> > This patch series does the following:
> >  - Reorganize the Clock Handling in Arasan SD driver
> >  - Adds new sampling clock in Arasan SD driver
> >  - Adds support to set Clock Delays in SD Arasan Driver
> >  - Add SDIO Tap Delay handling in ZynqMP firmware driver
> >  - Add support for ZynqMP Tap Delays setting in Arasan SD driver
> >
> > Changes in v2:
> >         - Replaced the deprecated calls to clock framework APIs
> >         - Added support for dev_clk_get() call to work for SD card clock
> >         - Separated the clock data struct
> >         - Fragmented the patch series in smaller patches to make it more
> >           readable
> >
> > Changes in v3:
> >         - Reverted "Replaced the deprecated calls to clock framework APIs"
> >         - Removed devm_clk_get() call which was added in v2
> >
> > Changes in v4:
> >         - Made the Phase Delay properties Arasan specific
> >
> > Changes in v5:
> >         - Made Clock Phase Delay properties common
> >         - Moved documentation of them to the common mmc documentation.
> >
> > Changes in v6:
> >         - Clubbed all Clk Phase Delay properties' into a pattern
> >           Property
> >
> > Manish Narani (8):
> >   mmc: sdhci-of-arasan: Separate out clk related data to another
> >     structure
> >   dt-bindings: mmc: arasan: Update Documentation for the input clock
> >   mmc: sdhci-of-arasan: Add sampling clock for a phy to use
> >   dt-bindings: mmc: Add optional generic properties for mmc
> >   mmc: sdhci-of-arasan: Add support to set clock phase delays for SD
> >   firmware: xilinx: Add SDIO Tap Delay nodes
> >   dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller
> >   mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup
> >
> >  .../devicetree/bindings/mmc/arasan,sdhci.txt  |  25 +-
> >  .../bindings/mmc/mmc-controller.yaml          |  13 +
> >  drivers/mmc/host/sdhci-of-arasan.c            | 478 +++++++++++++++++-
> >  include/linux/firmware/xlnx-zynqmp.h          |  13 +-
> >  4 files changed, 497 insertions(+), 32 deletions(-)
> >
> > --
> > 2.17.1
> >
> 
> Applied for next, assuming Rob is okay with patch4, otherwise you need
> to send a fix on top, thanks!
> 
> Kind regards
> Uffe

Thank you so much for your reviews and continuous support! :)
Looking forward to work more with you on this.

Regards,
Manish