Re: [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions

[Paolo Bonzini]

On 19/11/19 09:49, Yang Weijiang wrote:
> +static int is_spp_shadow_present(u64 pte)
> +{
> +	return pte & PT_PRESENT_MASK;
> +}
> +

This should not be needed, is_shadow_present_pte works well for SPP PTEs
as well (and in fact you're already using it here and there, so it's
confusing to have both).

Paolo