Re: [PATCH 1/1] ARM: dts: am5729: beaglebone-ai: adding device tree

[Grygorii Strashko]

On 19/11/2019 22:28, Caleb Robey wrote:
> From: Jason Kridner <jdk@xxxxxx>
>
> BeagleBoard.org BeagleBone AI is an open source hardware single
> board computer based on the Texas Instruments AM5729 SoC featuring
> dual-core 1.5GHz Arm Cortex-A15 processor, dual-core C66 digital
> signal processor (DSP), quad-core embedded vision engine (EVE),
> Arm Cortex-M4 processors, dual programmable realtime unit
> industrial control subsystems and more. The board features 1GB
> DDR3L, USB3.0 Type-C, USB HS Type-A, microHDMI, 16GB eMMC flash,
> 1G Ethernet, 802.11ac 2/5GHz, Bluetooth, and BeagleBone expansion
> headers.
>
> For more information, refer to:
> https://beaglebone.ai


> This patch introduces the BeagleBone AI device tree.
>
> Note that the device use the "ti,tpd12s016" component which is
> software compatible with "ti,tpd12s015". Thus we only use the
> latter driver.
>
> Signed-off-by: Jason Kridner <jdk@xxxxxx>
> Signed-off-by: Caleb Robey <c-robey@xxxxxx>
> Cc: Robert Nelson <robertcnelson@xxxxxxxxx>
>
> ---
>   arch/arm/boot/dts/Makefile                |   1 +
>   arch/arm/boot/dts/am5729-beagleboneai.dts | 782 ++++++++++++++++++++++
>   2 files changed, 783 insertions(+)
>   create mode 100644 arch/arm/boot/dts/am5729-beagleboneai.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b21b3a64641a..b1154dbda73c 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile

[..]

> +
> +&uart1 {
> +	status = "okay";
> +};
> +
> +&davinci_mdio {
> +	reset-gpios = <&gpio2 23 GPIO_ACTIVE_LOW>;
> +	reset-delay-us = <2>;
> +
> +	phy0: ethernet-phy@1 {
> +		reg = <4>;
> +		compatible = "ethernet-phy-id004d.d072",
> +			"ethernet-phy-ieee802.3-c22";

Pls, do not ignore my comments.

Above compatible should not be required.

> +		eee-broken-100tx;
> +		eee-broken-1000t;
> +	};
> +};
> +
> +&mac {
> +	slaves = <1>;
> +	status = "okay";
> +};

Pls, move cpsw node here

> +
> +&ocp {
> +	pruss1_shmem: pruss_shmem@4b200000 {
> +		status = "okay";
> +		compatible = "ti,pruss-shmem";
> +		reg = <0x4b200000 0x020000>;
> +	};
> +

[..]

> +
> +&cpsw_emac0 {
> +	phy-handle = <&phy0>;
> +	phy-mode = "rgmii";
> +};

Move it up, pls.

--
Best regards,
grygorii