Re: [PATCH 2/4] virtiofs: Add an index to keep track of first request queue

From: Stefan Hajnoczi
Date: Thu Nov 21 2019 - 11:00:54 EST


On Fri, Nov 15, 2019 at 03:57:03PM -0500, Vivek Goyal wrote:
> @@ -990,7 +994,7 @@ static int virtio_fs_enqueue_req(struct virtio_fs_vq *fsvq,
> static void virtio_fs_wake_pending_and_unlock(struct fuse_iqueue *fiq)
> __releases(fiq->lock)
> {
> - unsigned int queue_id = VQ_REQUEST; /* TODO multiqueue */
> + unsigned int queue_id;
> struct virtio_fs *fs;
> struct fuse_req *req;
> struct virtio_fs_vq *fsvq;

Sorry, I removed too much context in my reply. This TODO...

> @@ -1004,6 +1008,7 @@ __releases(fiq->lock)
> spin_unlock(&fiq->lock);
>
> fs = fiq->priv;
> + queue_id = fs->first_reqq_idx;

...should be moved here.

Attachment: signature.asc
Description: PGP signature