Re: possible deadlock in mon_bin_vma_fault

From: Alan Stern
Date: Thu Nov 21 2019 - 11:20:22 EST


On Thu, 21 Nov 2019, Pete Zaitcev wrote:

> Anyway... If you are looking at it too, what do you think about not using
> any locks in mon_bin_vma_fault() at all? Isn't it valid? I think I tried
> to be "safe", but it only uses things that are constants unless we're
> opening and closing; a process cannot make page faults unless it has
> some thing mapped; and that is only possible if device is open and stays
> open. Can you find a hole in this reasoning?

I think you're right. But one thing concerns me: What happens if the
same buffer is mapped by more than one process? Do you allow that? I
haven't read the code in enough detail to see.

Alan Stern