Re: [PATCH] drivers: usb: consolidate USB vendor IDs in one include file

From: Greg KH
Date: Thu Nov 21 2019 - 11:33:18 EST


On Thu, Nov 21, 2019 at 05:17:42PM +0100, Enrico Weigelt, metux IT consult wrote:
> Instead of redefining usb vendor IDs in several places, consolidate
> into one include file: include/linux/usb/usb_ids.h

No, please no.

There's a specific reason we do not have this, unlike other operating
systems. It's because merges are a pain, and touching the "big one
file" ends up rebuilding too many things.

Read the top of the pci-ids.h file for why I do not want to see us do
this for any other type of id. It's best to leave them where they are
used, right in the driver itself.

thanks,

greg k-h