Re: [PATCH v4 0/2] tps6105x add devicetree and leds support

From: Jacek Anaszewski
Date: Thu Nov 21 2019 - 13:20:47 EST


Hi Sven,

Thank you for the updated set.

For both patches:

Acked-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>

Best regards,
Jacek Anaszewski

On 11/21/19 3:27 PM, Sven Van Asbroeck wrote:
> v3 -> v4:
> Removed tps6105 mfd patch - it was accepted (Mark Brown).
>
> Use the new LED registration API - suggested by Jacek Anaszewski.
>
> Updated led dt bindings to document function, color usage.
>
> v2 -> v3:
> Removed tps6105x regulator patch - it was accepted (Mark Brown).
>
> Removed devicetree/platdata bindings for tps6105x led naming.
> I can test only with a 4.19 vendor kernel, which does not have the
> latest led naming infrastructure (function/color). Drop devicetree/
> fwnode/pdata led naming in favour of hard-coding to "tps6105x::torch",
> so the patch can be tested by me, yet remains acceptable to upstream.
>
> v1 -> v2:
> Select chip operational mode by looking at subnode name, _not_ its
> compatible property. Suggested by Mark Brown.
>
> I needed led operation for this mfd chip, so I added a very simple
> driver for this.
>
> My platform (arm imx6q) is devicetree-based, so I added optional
> devicetree support for this chip and its sub-drivers.
>
> Sven Van Asbroeck (2):
> leds: tps6105x: add driver for mfd chip led mode
> dt-bindings: mfd: update TI tps6105x chip bindings
>
> .../devicetree/bindings/mfd/tps6105x.txt | 47 ++++++++++-
> drivers/leds/Kconfig | 10 +++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-tps6105x.c | 83 +++++++++++++++++++
> 4 files changed, 140 insertions(+), 1 deletion(-)
> create mode 100644 drivers/leds/leds-tps6105x.c
>