Re: [PATCH v2 2/2] arm64: dts: freescale: add initial support for Google i.MX 8MQ Phanbell

[Fabio Estevam]

Hi Marco,

On Thu, Nov 21, 2019 at 1:25 PM Marco Antonio Franchi
<marco.franchi@xxxxxxx> wrote:
>
> This patch adds the device tree to support Google Coral Edge TPU,
> historicaly named as fsl-imx8mq-phanbell, a computer on module
> which can be used for AI/ML propose.
>
> It introduces a minimal enablement support for this module and
> was totally based on the NXP i.MX 8MQ EVK board and i.MX 8MQ Phanbell

Please remove the "totally based on the NXP i.MX 8MQ EVK board" as
they are different boards.

> +       memory@40000000 {
> +               device_type = "memory";
> +               reg = <0x00000000 0x40000000 0 0xc0000000>;

The memory size here does not match with the one used in the Google repo.

With these changes you can add:

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>