RE: [PATCH v4 04/13] exfat: add directory operations

[Namjae Jeon]

> 
> â
> > +++ b/fs/exfat/dir.c
> â
> > +static int exfat_readdir(struct inode *inode, struct exfat_dir_entry
> *dir_entry)
> > +{
> â
> > +			if (!ep) {
> > +				ret = -EIO;
> > +				goto free_clu;
> > +			}
> 
> How do you think about to move a bit of common exception handling code
> (at similar places)?
Not sure it is good. Other review comments are okay. Will fix them on v5.
> 
> +			if (!ep)
> +				goto e_io;
> 
> 
> â
> > +free_clu:
> > +	kfree(clu);
> > +	return ret;
> 
> +
> +e_io:
> +	ret = -EIO;
> +	goto free_clu;
> 
> > +}