Re: [PATCH 1/6] x86/fpu/xstate: Fix small issues before adding supervisor xstates

From: Borislav Petkov
Date: Fri Nov 22 2019 - 16:55:16 EST


On Fri, Nov 22, 2019 at 01:22:37PM -0800, Yu-cheng Yu wrote:
> This implicitly converts a u32 to a bool. By looking at it, I think it
> should be OK, but wonder if anything overlooked? I would be happy to
> make this a separate patch.

I don't understand your question: are you asking whether you should
convert the functions to "static bool" or what is your question?

If it is that, then yes pls. Also, change xfeature_is_user() to return
bool too, while at it.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette