RE: [PATCH] arm64: dts: realtek: Add Realtek rtd1619 and mjolnir
From: James Tai
Date: Sat Nov 23 2019 - 03:42:55 EST
Hi Andreas,
>
> MMIO, for GICD and GICR. It's about fixing the ranges of the /soc node:
>
> My proposed
> ranges = <0x98000000 0x98000000 0x68000000>; needs to be split, with a gap
> between r-bus and GIC for continued RAM.
>
> https://github.com/afaerber/linux/commit/1884ec6a533c9d5c2b6ca40ee138ff
> 7e8312b6c8
>
> This goes back to Rob's review of RTD1295 [1], where we then for lack of
> memory space documentation assumed that everything beyond 2 GiB would
> be potential register space. Here we're dealing with up to 4 GiB though.
>
>
> James, are you planning to send a fix-up patch here? If not, you'll need to tell
> me what values to use, e.g., is there a NOR flash region on RTD1619, and does
> RAM continue also in between and after GIC, or is there some timer register
> behind it, like on RTD1195?
>
> ranges = <0x00000000 0x00000000 0x00030000>, // ??? boot ROM size
> <0x98000000 0x98000000 0x00200000>, // r-bus
> // anything here? e.g., NOR flash?
> <0xff100000 0xff100000 0x00010000>, // GICD
> <0xff140000 0xff140000 0x000c0000>; // GICR
> // anything here? e.g., timer enable?
>
> ranges = <0x00000000 0x00000000 0x00030000>,
> <0x98000000 0x98000000 0x00200000>,
> <0xff100000 0xff100000 0x00100000>; // whole GIC?
>
Yes, I'll send a fix-up patch.
Regards,
James