Re: [PATCH v1] mt76: mt7615: Fix build with older compilers

From: Pablo SebastiÃn Greco
Date: Mon Dec 02 2019 - 05:30:27 EST



On 2/12/19 06:18, Sergei Shtylyov wrote:
Hello!

On 01.12.2019 21:17, Pablo Greco wrote:

Some compilers (tested with 4.8.5 from CentOS 7) fail properly process

ÂÂ Fail to?
Right

FIELD_GET inside an inline function, which ends up in a BUILD_BUG_ON.
Convert inline function to a macro.

Fixes commit bf92e7685100 ("mt76: mt7615: add support for per-chain
signal strength reporting")

ÂÂ Should be:

Fixes: bf92e7685100 ("mt76: mt7615: add support for per-chain signal strength reporting")

ÂÂ Do not ever break up the Fixes: line and don't insert empty lines between it and other tags.
Ack, I'll fix those for v2

Reported in https://lkml.org/lkml/2019/9/21/146

Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Signed-off-by: Pablo Greco <pgreco@xxxxxxxxxxxxxxxxx>
[...]

MBR, Sergei


Thanks, Pablo