Re: [PATCH] drivers/misc: ti-st: remove redundant assignment to variable i

[Dan Carpenter]

On Mon, Dec 02, 2019 at 03:13:52PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The variable i is being initialized with a value that is never
> read and it is being updated later with a new value in a for-loop.
> The initialization is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/misc/ti-st/st_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
> index 2ae9948a91e1..6255d9b88122 100644
> --- a/drivers/misc/ti-st/st_core.c
> +++ b/drivers/misc/ti-st/st_core.c
> @@ -736,7 +736,7 @@ static int st_tty_open(struct tty_struct *tty)
>  
>  static void st_tty_close(struct tty_struct *tty)
>  {
> -	unsigned char i = ST_MAX_CHANNELS;
> +	unsigned char i;
>  	unsigned long flags = 0;

I'm surprised that flags doesn't generate a warning as well.

regards,
dan carpenter