RE: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS

[Alim Akhtar]

> -----Original Message-----
> From: sheebab <sheebab@xxxxxxxxxxx>
> Sent: 03 December 2019 15:37
> To: alim.akhtar@xxxxxxxxxxx; avri.altman@xxxxxxx;
> pedrom.sousa@xxxxxxxxxxxx; jejb@xxxxxxxxxxxxx;
> martin.petersen@xxxxxxxxxx; stanley.chu@xxxxxxxxxxxx;
> beanhuo@xxxxxxxxxx; yuehaibing@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; vigneshr@xxxxxx
> Cc: mparab@xxxxxxxxxxx; rafalc@xxxxxxxxxxx; sheebab
> <sheebab@xxxxxxxxxxx>
> Subject: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS
> 
> This patch disables autohibern8 feature in Cadence UFS.
> The autohibern8 feature has issues due to which unexpected interrupt
trigger is
> happening. After the interrupt issue is sorted out autohibern8 feature
will be re-
> enabled
> 
> Signed-off-by: sheebab <sheebab@xxxxxxxxxxx>
> ---
Probably we want to mark this as FIX for the older kernel version?
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

>  drivers/scsi/ufs/cdns-pltfrm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/cdns-pltfrm.c
b/drivers/scsi/ufs/cdns-pltfrm.c index
> b2af04c57a39..882425d1166b 100644
> --- a/drivers/scsi/ufs/cdns-pltfrm.c
> +++ b/drivers/scsi/ufs/cdns-pltfrm.c
> @@ -98,6 +98,12 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba
> *hba,
>  	 * completed.
>  	 */
>  	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
> +
> +	/*
> +	 * Disabling Autohibern8 feature in cadence UFS
> +	 * to mask unexpected interrupt trigger.
> +	 */
> +	hba->ahit = 0;
> 
>  	return 0;
>  }
> --
> 2.17.1