Re: [PATCH] ASoC: cs42l51: add dac mux widget in codec routes

From: Olivier MOYSAN
Date: Tue Dec 03 2019 - 10:12:49 EST


Hello Mark,

On 12/3/19 3:39 PM, Mark Brown wrote:
> On Tue, Dec 03, 2019 at 03:16:27PM +0100, Olivier Moysan wrote:
>
>> - SND_SOC_DAPM_DAC_E("Left DAC", "Left HiFi Playback",
>> - CS42L51_POWER_CTL1, 5, 1,
>> - cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD),
>> - SND_SOC_DAPM_DAC_E("Right DAC", "Right HiFi Playback",
>> - CS42L51_POWER_CTL1, 6, 1,
>> - cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD),
>> + SND_SOC_DAPM_DAC_E("Left DAC", NULL, CS42L51_POWER_CTL1, 5, 1,
>> + cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD),
>> + SND_SOC_DAPM_DAC_E("Right DAC", NULL, CS42L51_POWER_CTL1, 6, 1,
>> + cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD),
> This looks like an unrelated formatting change?
The reason of this change is to replace "HiFi Playback" by NULL, in
order to connect
DAC widget to DAC mux widget, instead of connecting it directly to Playback.

Regards
Olivier