Re: [PATCH] [EFI,PCI] Allow disabling PCI busmastering on bridges during boot

From: kbuild test robot
Date: Tue Dec 03 2019 - 13:23:51 EST

Hi Matthew,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.4-rc8]
[cannot apply to efi/next linus/master linux/master v5.4 v5.4-rc7 next-20191202 next-20191203]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Matthew-Garrett/Allow-disabling-PCI-busmastering-on-bridges-during-boot/20191203-084747
base: af42d3466bdc8f39806b26f593604fdc54140bcb
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

In file included from drivers/firmware//efi/libstub/pci.c:12:0:
drivers/firmware//efi/libstub/pci.c: In function 'efi_pci_disable_bridge_busmaster':
>> arch/arm64/include/asm/efi.h:96:33: error: 'sys_table_arg' undeclared (first use in this function); did you mean 'sys_table'?
#define efi_call_early(f, ...) sys_table_arg->boottime->f(__VA_ARGS__)
^
>> drivers/firmware//efi/libstub/pci.c:29:11: note: in expansion of macro 'efi_call_early'
status = efi_call_early(locate_handle,
^~~~~~~~~~~~~~
arch/arm64/include/asm/efi.h:96:33: note: each undeclared identifier is reported only once for each function it appears in
#define efi_call_early(f, ...) sys_table_arg->boottime->f(__VA_ARGS__)
^
>> drivers/firmware//efi/libstub/pci.c:29:11: note: in expansion of macro 'efi_call_early'
status = efi_call_early(locate_handle,
^~~~~~~~~~~~~~
>> arch/arm64/include/asm/efi.h:105:3: error: called object is not a function or function pointer
((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
~^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/firmware//efi/libstub/pci.c:62:12: note: in expansion of macro 'efi_call_proto'
status = efi_call_proto(efi_pci_io_protocol, pci.read, pci,
^~~~~~~~~~~~~~
>> arch/arm64/include/asm/efi.h:105:3: error: called object is not a function or function pointer
((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
~^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/firmware//efi/libstub/pci.c:70:12: note: in expansion of macro 'efi_call_proto'
status = efi_call_proto(efi_pci_io_protocol, pci.read, pci,
^~~~~~~~~~~~~~
>> arch/arm64/include/asm/efi.h:105:3: error: called object is not a function or function pointer
((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
~^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/firmware//efi/libstub/pci.c:78:12: note: in expansion of macro 'efi_call_proto'
status = efi_call_proto(efi_pci_io_protocol, pci.write, pci,
^~~~~~~~~~~~~~
--
In file included from drivers/firmware/efi/libstub/pci.c:12:0:
drivers/firmware/efi/libstub/pci.c: In function 'efi_pci_disable_bridge_busmaster':
>> arch/arm64/include/asm/efi.h:96:33: error: 'sys_table_arg' undeclared (first use in this function); did you mean 'sys_table'?
#define efi_call_early(f, ...) sys_table_arg->boottime->f(__VA_ARGS__)
^
drivers/firmware/efi/libstub/pci.c:29:11: note: in expansion of macro 'efi_call_early'
status = efi_call_early(locate_handle,
^~~~~~~~~~~~~~
arch/arm64/include/asm/efi.h:96:33: note: each undeclared identifier is reported only once for each function it appears in
#define efi_call_early(f, ...) sys_table_arg->boottime->f(__VA_ARGS__)
^
drivers/firmware/efi/libstub/pci.c:29:11: note: in expansion of macro 'efi_call_early'
status = efi_call_early(locate_handle,
^~~~~~~~~~~~~~
>> arch/arm64/include/asm/efi.h:105:3: error: called object is not a function or function pointer
((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
~^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/firmware/efi/libstub/pci.c:62:12: note: in expansion of macro 'efi_call_proto'
status = efi_call_proto(efi_pci_io_protocol, pci.read, pci,
^~~~~~~~~~~~~~
>> arch/arm64/include/asm/efi.h:105:3: error: called object is not a function or function pointer
((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
~^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/firmware/efi/libstub/pci.c:70:12: note: in expansion of macro 'efi_call_proto'
status = efi_call_proto(efi_pci_io_protocol, pci.read, pci,
^~~~~~~~~~~~~~
>> arch/arm64/include/asm/efi.h:105:3: error: called object is not a function or function pointer
((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
~^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/firmware/efi/libstub/pci.c:78:12: note: in expansion of macro 'efi_call_proto'
status = efi_call_proto(efi_pci_io_protocol, pci.write, pci,
^~~~~~~~~~~~~~

vim +96 arch/arm64/include/asm/efi.h

a13b00778e89c4 Ard Biesheuvel 2014-07-02 95
a13b00778e89c4 Ard Biesheuvel 2014-07-02 @96 #define efi_call_early(f, ...) sys_table_arg->boottime->f(__VA_ARGS__)
fc37206427ce38 Ard Biesheuvel 2016-04-25 97 #define __efi_call_early(f, ...) f(__VA_ARGS__)
6d0ca4a47bf8cb David Howells 2017-02-06 98 #define efi_call_runtime(f, ...) sys_table_arg->runtime->f(__VA_ARGS__)
fc37206427ce38 Ard Biesheuvel 2016-04-25 99 #define efi_is_64bit() (true)
a13b00778e89c4 Ard Biesheuvel 2014-07-02 100
c4db9c1e8c70bc Lukas Wunner 2018-07-20 101 #define efi_table_attr(table, attr, instance) \
c4db9c1e8c70bc Lukas Wunner 2018-07-20 102 ((table##_t *)instance)->attr
c4db9c1e8c70bc Lukas Wunner 2018-07-20 103
3552fdf29f01e5 Lukas Wunner 2016-11-12 104 #define efi_call_proto(protocol, f, instance, ...) \
3552fdf29f01e5 Lukas Wunner 2016-11-12 @105 ((protocol##_t *)instance)->f(instance, ##__VA_ARGS__)
3552fdf29f01e5 Lukas Wunner 2016-11-12 106

:::::: The code at line 96 was first introduced by commit
:::::: a13b00778e89c405cb224ef0926be6d71682d2a2 efi/arm64: efistub: Move shared dependencies to <asm/efi.h>

:::::: TO: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
:::::: CC: Matt Fleming <matt.fleming@xxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation

Attachment: .config.gz
Description: application/gzip