Re: [PATCH RFC v7 net-next] netdev: pass the stuck queue to the timeout handler

From: Shannon Nelson
Date: Tue Dec 03 2019 - 14:47:49 EST


On 12/2/19 11:12 PM, Michael S. Tsirkin wrote:
This allows incrementing the correct timeout statistic without any mess.
Down the road, devices can learn to reset just the specific queue.

[...]
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index 20faa8d24c9f..f7beb1b9e9d6 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -1268,7 +1268,7 @@ static void ionic_tx_timeout_work(struct work_struct *ws)
rtnl_unlock();
}
-static void ionic_tx_timeout(struct net_device *netdev)
+static void ionic_tx_timeout(struct net_device *netdev, unsigned int txqueue)
{
struct ionic_lif *lif = netdev_priv(netdev);

[...]


For drivers/net/ethernet/pensando/ionic:
Acked-by: Shannon Nelson <snelson@xxxxxxxxxxx>