Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n
From: Lyude Paul
Date: Tue Dec 03 2019 - 16:31:31 EST
On Tue, 2019-12-03 at 10:33 +0100, Daniel Vetter wrote:
> On Mon, Dec 02, 2019 at 01:49:47PM -0500, Lyude Paul wrote:
> > Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>
> >
> > I'll go ahead and push this to drm-misc-next, thanks!
>
> drm-misc-next-fixes since it's in the merge window. drm-misc-next is for
> 5.6 already.
> -Daniel
Ahh, that explains things :). Pushed, thanks for the patches!
>
> > On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote:
> > > On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > > > On systems with STACKTRACE_SUPPORT=n, we get:
> > > >
> > > > WARNING: unmet direct dependencies detected for STACKTRACE
> > > > Depends on [n]: STACKTRACE_SUPPORT
> > > > Selected by [y]:
> > > > - STACKDEPOT [=y]
> > > >
> > > > and build errors such as:
> > > >
> > > > m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
> > > > (.text+0x11c): undefined reference to `save_stack_trace'
> > > >
> > > > Add the missing deendency on STACKTRACE_SUPPORT.
> > > >
> > > > Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking
> > > > for
> > > > debugging")
> > > > Cc: Lyude Paul <lyude@xxxxxxxxxx>
> > > > Cc: Sean Paul <sean@xxxxxxxxxx>
> > > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > >
> > > Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > >
> > > Gr{oetje,eeting}s,
> > >
> > > Geert
> > >
> > --
> > Cheers,
> > Lyude Paul
> >
--
Cheers,
Lyude Paul