Re: [PATCH 1/6] dt-bindings: clock: add bindings for RTD1619 clocks
From: Andreas FÃrber
Date: Wed Dec 04 2019 - 06:25:07 EST
Hi James,
[fixing Palmer]
Am 04.12.19 um 05:11 schrieb James Tai:
>> Am 03.12.19 um 08:45 schrieb James Tai:
>>> From: cylee12 <cylee12@xxxxxxxxxxx>
>>
>> Please fix the author (git commit --amend --author="...") and use an
>> appropriate git config setting (and communication to your team) to avoid this
>> reoccurring for new commits - already pointed out to James.
>>
>> BTW I wonder why we have so many seemingly unrelated people in CC
>> (Mediatek, RISC-V) that the patches and responses keep hanging in mailing list
>> moderation?
>
> I used the "get_maintainer.pl" to find the email address of maintainers. However,
> I'm so sorry for mistakenly adding some unrelated people to this mail.
Here's my git-send-email cccmd config that I recommend:
$ git config sendemail.cccmd
scripts/get_maintainer.pl --nogit-fallback --norolestats
--nogit-fallback suppresses Git history to be checked for previous
contributors, saving time and avoiding unrelated or outdated people.
--norolestats suppresses extensive "(...)" comments for the email
addresses, which might wrap and break during transmission or when people
reply.
In addition you obviously need to configure sendemail.to, and you may
want to add multiple cc lines to [sendemail] in your .git/config to
ensure all mails including cover letters reach LKML and LAKML, too:
$ git config --get-all sendemail.to
linux-realtek-soc@xxxxxxxxxxxxxxxxxxx
$ git config --get-all sendemail.cc
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
linux-kernel@xxxxxxxxxxxxxxx
Further, you need to ensure that you are sending from the right branch,
so that the latest MAINTAINERS file and scripts get used. As Paul
pointed out, Palmer's address is fixed in both linux-next and linux, so
it is really puzzling where you got that old address from...
Not understanding your setup, you'll have to debug on your own where
those addresses came from. Try git send-email --dry-run to review the CC
addresses before you send. You could also temporarily use --rolestats to
see the MAINTAINERS section they came from.
On the bright side, this time your patches arrived threaded correctly.
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer
HRB 36809 (AG NÃrnberg)