Re: [PATCH] i2400m/USB: fix error return when rx_size is too large

[Colin Ian King]

On 02/12/2019 21:13, David Miller wrote:
> From: Colin King <colin.king@xxxxxxxxxxxxx>
> Date: Mon,  2 Dec 2019 17:42:46 +0000
> 
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> Currently when the rx_size is too large the intended error
>> -EINVAL is not being returned as this is being assigned to
>> result rather than rx_skb. Fix this be setting rx_skb
>> to ERR_PTR(-EINVAL) so that the error is returned in rx_skb
>> as originally intended.
>>
>> Addresses-Coverity: ("Unused value")
>> Fixes: a8ebf98f5414 ("i2400m/USB: TX and RX path backends")
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> This leaks rx_skb, the caller is supposed to clean up rx_skb
> by freeing it if this function doesn't transmit it successfully.
> 
Oops, yes. Ignore this fix.

Colin