Re: [PATCH v2 0/3] perf report: Few fixes
From: Jiri Olsa
Date: Wed Dec 04 2019 - 07:07:30 EST
On Thu, Nov 14, 2019 at 06:52:10PM +0530, Ravi Bangoria wrote:
> v1: https://lore.kernel.org/r/20191112054946.5869-1-ravi.bangoria@xxxxxxxxxxxxx
>
> v1 fixed a segfault when -F phys_daddr is used in perf report without
> --mem-mode. Arnaldo suggested to bail out the option completely in
> such case instead of showing 0 values.
>
> Ravi Bangoria (3):
> perf hists: Replace pr_err with ui__error
> perf report: Make -F more strict like -s
> perf report: Error out for mem mode fields if mem info is not
> available
>
> tools/perf/builtin-report.c | 8 ++++++++
> tools/perf/util/sort.c | 16 +++++++++++-----
> 2 files changed, 19 insertions(+), 5 deletions(-)
looks good
Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
thanks,
jirka