Re: [PATCH 0/5] Add pinctrl support for dwapb gpio driver

[ClÃment Leger]

----- On 4 Dec, 2019, at 13:24, Andy Shevchenko andy.shevchenko@xxxxxxxxx wrote:

> On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@xxxxxxxxx> wrote:
>>
>> Synopsys DWAPB IP includes support for pin control. This control is basic
>> and allows to switch between a hardware and a software function.
>> Software function is when driving GPIOs from IP and hardware is controlled
>> by external signals.
>> This serie export necessary interface to be able to move the driver to
>> pinctrl folder and then implement the pinctrl support which is based on the
>> digicolor driver. The idea is to avoid hardcoding pins in driver since
>> this IP is a generic one available on multiple SoC.
>>
> 
> This series misses at least GPIO ACPI maintainers to be Cc'ed to for
> the certain changes.
> Moreover, I would like to see entire series in the future in my mailbox.

Sorry, I messed up with get_maintainer.pl while sending the serie.
I can resend it properly if needed.

> 
> I will look at v1 closer anyway.
> 
>> Clement Leger (5):
>>   gpio: export acpi_gpiochip_request_interrupts in gpio/driver.h
>>   pinctrl: dw: move gpio-dwapb.c to pinctrl folder
>>   pinctrl: dw: use devm_gpiochip_add_data
>>   pinctrl: dw: add pinctrl support for dwapb gpio driver
>>   dt-bindings: pinctrl: dw: move sps,dwapb-gpio.txt to pinctrl
>>
>>  .../bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt |  21 +-
>>  MAINTAINERS                                        |   6 +-
>>  drivers/gpio/Kconfig                               |   8 -
>>  drivers/gpio/Makefile                              |   1 -
>>  drivers/gpio/gpiolib-acpi.h                        |   4 -
>>  drivers/pinctrl/Kconfig                            |   1 +
>>  drivers/pinctrl/Makefile                           |   1 +
>>  drivers/pinctrl/dw/Kconfig                         |  11 +
>>  drivers/pinctrl/dw/Makefile                        |   4 +
>>  .../gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c}    | 277 +++++++++++++++++++--
>>  include/linux/gpio/driver.h                        |  12 +
>>  include/linux/platform_data/gpio-dwapb.h           |   1 +
>>  12 files changed, 310 insertions(+), 37 deletions(-)
>>  rename Documentation/devicetree/bindings/{gpio => pinctrl}/snps-dwapb-gpio.txt
>>  (76%)
>>  create mode 100644 drivers/pinctrl/dw/Kconfig
>>  create mode 100644 drivers/pinctrl/dw/Makefile
>>  rename drivers/{gpio/gpio-dwapb.c => pinctrl/dw/pinctrl-dwapb.c} (77%)
>>
>> --
>> 2.15.0.276.g89ea799
>>
> 
> 
> --
> With Best Regards,
> Andy Shevchenko