Re: [PATCH v2 1/4] sched/uclamp: Make uclamp_util_*() helpers use and return UL values

From: Valentin Schneider
Date: Wed Dec 04 2019 - 12:35:57 EST


On 04/12/2019 17:29, Vincent Guittot wrote:
>> True. I'm not too hot on having to handle rq clamp values
>> (rq->uclamp[x].value) and task clamp values (uclamp_eff_value())
>> differently (cast one but not the other), but I don't feel *too* strongly
>> about this, so if you want I can do that change for v3.
>
> Yes please. This makes the code easier to read and understand.
>

Will do.

> The rest of the patch series looks good to me. So feel free to add my
> reviewed by on the next version
> Reviewed-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>>

Thanks!