Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error

[Randy Dunlap]

On 12/4/19 7:01 PM, Rahul Tanwar wrote:
> Fix below linker error
> 
>     ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
>     `pinconf_generic_dt_node_to_map_all':
>     pinctrl-equilibrium.c:(.text+0xb): undefined reference
>     to `pinconf_generic_dt_node_to_map'
> 
> Caused by below commit
> 
>     1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
> 
> by adding 'depends on OF' in Kconfig driver entry.
> 
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@xxxxxxxxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested


Thanks.

> ---
>  drivers/pinctrl/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 3bfbf2ff6e2b..ba0cad4bd072 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -422,6 +422,7 @@ config PINCTRL_TB10X
>  
>  config PINCTRL_EQUILIBRIUM
>  	tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
> +	depends on OF
>  	select PINMUX
>  	select PINCONF
>  	select GPIOLIB
> 


-- 
~Randy