Re: [PATCH 17/18] dyndbg: rename dynamic_debug to dyndbg
From: Andy Shevchenko
Date: Thu Dec 05 2019 - 17:25:06 EST
On Thu, Dec 5, 2019 at 11:54 PM Jim Cromie <jim.cromie@xxxxxxxxx> wrote:
>
> This rename fixes a subtle usage wrinkle; the __setup() names didn't
> match the fake "dyndbg" module parameter used to enable dynamic-printk
> callsites in modules. See the last change in Docs for the effect.
>
> It also shortens the "__FILE__:__func__" prefix in dyndbg.verbose
> messages, effectively s/dynamic_debug/dyndbg/
>
> This is a 99.9% rename; trim_prefix and debugfs_create_dir arg excepted.
> Nonetheless, it also changes both /sys appearances:
>
> bash-5.0# ls -R /sys/kernel/debug/dyndbg/ /sys/module/dyndbg/parameters/
> /sys/kernel/debug/dyndbg/:
> control
> /sys/module/dyndbg/parameters/:
Isn't this path a part of ABI?
> verbose
>
> Finally, paths in docs are ~= s|/dynamic_debug/|/dyndbg/|,
> plus the kernel cmdline example tweak cited above.
--
With Best Regards,
Andy Shevchenko