Re: [PATCH 1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional gpio

[Sean Nyekjaer]

On 05/12/2019 08.36, Sean Nyekjaer wrote:
> On 04/12/2019 18.51, Dan Murphy wrote:
> > The wake-up of the device can be configured as an optional
> > feature of the device. Move the wake-up gpio from a requried
> > property to an optional property.
> >
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > CC: Rob Herring <robh@xxxxxxxxxx>
> Reviewed-by: Sean Nyekjaer <sean@xxxxxxxxxx>
Tested-by: Sean Nyekjaer <sean@xxxxxxxxxx>
> > ---
> > Â Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
> > Â 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt 
> > b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> > index 27e1b4cebfbd..7cf5ef7acba4 100644
> > --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> > +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> > @@ -10,7 +10,6 @@ Required properties:
> > ÂÂÂÂÂ - #size-cells: 0
> > ÂÂÂÂÂ - spi-max-frequency: Maximum frequency of the SPI bus the chip can
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ operate at should be less than or equal to 18 MHz.
> > -ÂÂÂ - device-wake-gpios: Wake up GPIO to wake up the TCAN device.
> > ÂÂÂÂÂ - interrupt-parent: the phandle to the interrupt controller 
> > which provides
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ the interrupt.
> > ÂÂÂÂÂ - interrupts: interrupt specification for data-ready.
> > @@ -23,6 +22,7 @@ Optional properties:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ reset.
> > ÂÂÂÂÂ - device-state-gpios: Input GPIO that indicates if the device is in
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ a sleep state or if the device is active.
> > +ÂÂÂ - device-wake-gpios: Wake up GPIO to wake up the TCAN device.
> > Â Example:
> > Â tcan4x5x: tcan4x5x@0 {