Re: [PATCH 1/3] libperf: Move libperf under tools/lib/perf

[Arnaldo Carvalho de Melo]

Em Fri, Dec 06, 2019 at 04:07:06PM +0100, Jiri Olsa escreveu:
> On Fri, Dec 06, 2019 at 11:27:54AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Dec 06, 2019 at 02:55:11PM +0100, Jiri Olsa escreveu:
> > > Moving libperf from its current location under perf
> > > to separate directory under tools/lib.
> > 
> > Breaks the build/bisection:
> 
> yes, I noted that in the cover email, the 2nd patch repairs paths,
> but those changes would get lost in the move.. I can squash it
> if you want, but I thought this is more transparent despite the
> one-commit-long broken bisect ;-)

It may well be, but bisection for me is of primary importance, so please
avoid breaking it,

Thanks,

- Arnaldo
 
> jirka
> 
> > 
> > [acme@quaco perf]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; make O=/tmp/build/perf  -C tools/perf install-bin
> > make: Entering directory '/home/acme/git/perf/tools/perf'
> >   BUILD:   Doing 'make -j8' parallel build
> >   HOSTCC   /tmp/build/perf/fixdep.o
> >   HOSTLD   /tmp/build/perf/fixdep-in.o
> >   LINK     /tmp/build/perf/fixdep
> > 
> > Auto-detecting system features:
> > ...                         dwarf: [ on  ]
> > ...            dwarf_getlocations: [ on  ]
> > ...                         glibc: [ on  ]
> > ...                          gtk2: [ on  ]
> > ...                      libaudit: [ on  ]
> > ...                        libbfd: [ on  ]
> > ...                        libcap: [ on  ]
> > ...                        libelf: [ on  ]
> > ...                       libnuma: [ on  ]
> > ...        numa_num_possible_cpus: [ on  ]
> > ...                       libperl: [ on  ]
> > ...                     libpython: [ on  ]
> > ...                     libcrypto: [ on  ]
> > ...                     libunwind: [ on  ]
> > ...            libdw-dwarf-unwind: [ on  ]
> > ...                          zlib: [ on  ]
> > ...                          lzma: [ on  ]
> > ...                     get_cpuid: [ on  ]
> > ...                           bpf: [ on  ]
> > ...                        libaio: [ on  ]
> > ...                       libzstd: [ on  ]
> > ...        disassembler-four-args: [ on  ]
> > 
> >   GEN      /tmp/build/perf/common-cmds.h
> > make[3]: *** /home/acme/git/perf/tools/perf/lib/: No such file or directory.  Stop.
> > make[2]: *** [Makefile.perf:785: /tmp/build/perf/libperf.a] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >   MKDIR    /tmp/build/perf/fd/
> >   MKDIR    /tmp/build/perf/fs/
> >   CC       /tmp/build/perf/exec-cmd.o
> >   CC       /tmp/build/perf/fd/array.o
> >   CC       /tmp/build/perf/fs/fs.o
> >   CC       /tmp/build/perf/cpu.o
> >   CC       /tmp/build/perf/help.o
> >   LD       /tmp/build/perf/fd/libapi-in.o
> >   CC       /tmp/build/perf/event-parse.o
> >   CC       /tmp/build/perf/event-plugin.o
> >   CC       /tmp/build/perf/pager.o
> >   CC       /tmp/build/perf/debug.o
> >   CC       /tmp/build/perf/str_error_r.o
> >   CC       /tmp/build/perf/trace-seq.o
> >   MKDIR    /tmp/build/perf/fs/
> >   CC       /tmp/build/perf/parse-filter.o
> >   CC       /tmp/build/perf/parse-options.o
> >   MKDIR    /tmp/build/perf/staticobjs/
> >   CC       /tmp/build/perf/fs/tracing_path.o
> >   CC       /tmp/build/perf/run-command.o
> >   CC       /tmp/build/perf/staticobjs/libbpf.o
> >   CC       /tmp/build/perf/parse-utils.o
> >   CC       /tmp/build/perf/kbuffer-parse.o
> >   MKDIR    /tmp/build/perf/staticobjs/
> >   CC       /tmp/build/perf/sigchain.o
> >   LD       /tmp/build/perf/fs/libapi-in.o
> >   CC       /tmp/build/perf/staticobjs/bpf.o
> >   CC       /tmp/build/perf/subcmd-config.o
> >   CC       /tmp/build/perf/staticobjs/nlattr.o
> >   CC       /tmp/build/perf/tep_strerror.o
> >   CC       /tmp/build/perf/event-parse-api.o
> >   CC       /tmp/build/perf/staticobjs/btf.o
> >   LD       /tmp/build/perf/libapi-in.o
> >   LD       /tmp/build/perf/libsubcmd-in.o
> >   CC       /tmp/build/perf/staticobjs/libbpf_errno.o
> >   CC       /tmp/build/perf/staticobjs/str_error.o
> >   CC       /tmp/build/perf/staticobjs/netlink.o
> >   CC       /tmp/build/perf/staticobjs/bpf_prog_linfo.o
> >   AR       /tmp/build/perf/libapi.a
> >   LD       /tmp/build/perf/libtraceevent-in.o
> >   CC       /tmp/build/perf/staticobjs/libbpf_probes.o
> >   CC       /tmp/build/perf/staticobjs/xsk.o
> >   AR       /tmp/build/perf/libsubcmd.a
> >   CC       /tmp/build/perf/staticobjs/btf_dump.o
> >   CC       /tmp/build/perf/staticobjs/hashmap.o
> >   LINK     /tmp/build/perf/libtraceevent.a
> >   LD       /tmp/build/perf/staticobjs/libbpf-in.o
> >   LINK     /tmp/build/perf/libbpf.a
> >   PERF_VERSION = 5.4.ge59599b355da
> > make[1]: *** [Makefile.perf:225: sub-make] Error 2
> > make: *** [Makefile:110: install-bin] Error 2
> > make: Leaving directory '/home/acme/git/perf/tools/perf'
> > [acme@quaco perf]$
> > 

-- 

- Arnaldo