Re: [PATCH] drm: Add FEC registers for LT-tunable repeaters

[Harry Wentland]

On 2019-12-05 8:58 a.m., Rodrigo Siqueira wrote:
> FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP
> 1.4a. This commit adds the address registers for
> FEC_ERROR_COUNT_PHY_REPEATER1 and FEC_CAPABILITY_PHY_REPEATER1.
> 
> Cc: Abdoulaye Berthe <Abdoulaye.Berthe@xxxxxxx>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Leo Li <sunpeng.li@xxxxxxx>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> Cc: Manasi Navare <manasi.d.navare@xxxxxxxxx>
> Cc: Ville SyrjÃlà <ville.syrjala@xxxxxxxxxxxxxxx>
> Signed-off-by: Abdoulaye Berthe <Abdoulaye.Berthe@xxxxxxx>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>

Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>

Harry

> ---
>  include/drm/drm_dp_helper.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 51ecb5112ef8..b2057009aabc 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1042,6 +1042,8 @@
>  #define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1	    0xf0039 /* 1.3 */
>  #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1	    0xf003b /* 1.3 */
>  #define DP_FEC_STATUS_PHY_REPEATER1			    0xf0290 /* 1.4 */
> +#define DP_FEC_ERROR_COUNT_PHY_REPEATER1                    0xf0291 /* 1.4 */
> +#define DP_FEC_CAPABILITY_PHY_REPEATER1                     0xf0294 /* 1.4a */
>  
>  /* Repeater modes */
>  #define DP_PHY_REPEATER_MODE_TRANSPARENT		    0x55    /* 1.3 */
>